Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: added all the back arrows on screens that needed it #234

Merged
merged 3 commits into from
May 24, 2024

Conversation

GaelCondeLosada
Copy link
Collaborator

@GaelCondeLosada GaelCondeLosada commented May 22, 2024

What I did

Added back arrows on all screen that were missing it.

How I did it

  • Added the component BackArrow in the screens.
  • Adapted the tests.

How to verify it

  • Open the app and check that the back arrow is on all screens that have one on the figma and that the arrow works correctly.
  • You can also run the tests.

Demo video

Pre-merge checklist

The changes I have introduced:

  • work correctly
  • do not break other functionalities
  • work correctly on Android
  • are fully tested

@GaelCondeLosada GaelCondeLosada linked an issue May 22, 2024 that may be closed by this pull request
@GaelCondeLosada GaelCondeLosada marked this pull request as ready for review May 22, 2024 18:11
@GaelCondeLosada GaelCondeLosada self-assigned this May 22, 2024
Copy link
Collaborator

@alexandre-mrt alexandre-mrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just for the external profile try to make the layout great again

Copy link
Collaborator

@alexandre-mrt alexandre-mrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@GaelCondeLosada GaelCondeLosada merged commit 9ef238c into main May 24, 2024
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add back arrow on all screens
2 participants