Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: qr codes on apk build #249

Merged
merged 3 commits into from
May 28, 2024
Merged

fix: qr codes on apk build #249

merged 3 commits into from
May 28, 2024

Conversation

GaelCondeLosada
Copy link
Collaborator

@GaelCondeLosada GaelCondeLosada commented May 27, 2024

What I did

Fixed the QR code scanning issues on the APK.

How to verify it

You can try to scan the QR code of someone with the application for the APK of this build: https://expo.dev/accounts/uniconnect-epfl/projects/uniconnect/builds/d2d965dc-106e-4bfb-884b-8115107b8089

Pre-merge checklist

The changes I have introduced:

  • work correctly
  • do not break other functionalities
  • work correctly on Android
  • are fully tested

@GaelCondeLosada GaelCondeLosada linked an issue May 27, 2024 that may be closed by this pull request
@GaelCondeLosada GaelCondeLosada self-assigned this May 27, 2024
@GaelCondeLosada GaelCondeLosada marked this pull request as ready for review May 27, 2024 15:33
Copy link
Collaborator

@AlbertoCentonze AlbertoCentonze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@GaelCondeLosada GaelCondeLosada merged commit d0b3a7d into main May 28, 2024
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: qr codes not working on the apk
2 participants