Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

multiple fixes regarding events #250

Conversation

GustaveCharles
Copy link
Collaborator

@GustaveCharles GustaveCharles commented May 27, 2024

What I did

  • I added the interests field in the events on the database
  • Interests are fetched dynamically in the ViewEventScreen
  • I have changed the onRefresh callback by a useFocusEffect callback in the EventScreen
  • I have modified the app.json for the maps api (with @Aidasvenc )

How I did it

  • I added interests in the createEvent function
  • I used useFocusEffect from "@react-navigation/native"

How to verify it

  • You can do the same as the video, and see on the one side that your new event is directly displayed, and on the other side that your new event has the corresponding interests.

Demo video

Enregistrement.de.l.ecran.2024-05-27.a.16.59.55.1.mov

Pre-merge checklist

The changes I have introduced:

  • work correctly
  • do not break other functionalities
  • work correctly on Android
  • are fully tested

Copy link

Copy link
Collaborator

@gaspardthrl gaspardthrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work

@GustaveCharles GustaveCharles linked an issue May 27, 2024 that may be closed by this pull request
@GustaveCharles GustaveCharles marked this pull request as ready for review May 27, 2024 15:30
@GustaveCharles GustaveCharles merged commit 142e4a5 into main May 27, 2024
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix an error in event page fix: app crashing when clicking on an event and having no friends (on apk)
3 participants