Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: solve layout and announcement problems #268

Merged
merged 13 commits into from
Jun 1, 2024

Conversation

alexandre-mrt
Copy link
Collaborator

@alexandre-mrt alexandre-mrt commented May 29, 2024

What I did

The app notifies the user when he has no events yet.
I added the sticky headers for the events screen so we know if we are seeing upcoming events or past ones.
We can now see the selected interests when we create an announcement

How I did it

I added an empty array for events in the creation method, so the query in the database is not throwing an error but retrieve an empty array. It's detected and a different message than "Error with your connection is shown".

How to verify it

You can check the event screen to see the sticky header.
You can try to go to the event screen without any events to see the correct notification "No events yet"
When selecting the interests for an announcement, you can now see what you selected.

Demo video

image image image

Pre-merge checklist

The changes I have introduced:

  • work correctly
  • do not break other functionalities
  • work correctly on Android
  • are fully tested

@alexandre-mrt alexandre-mrt marked this pull request as ready for review May 29, 2024 15:04
@AlbertoCentonze AlbertoCentonze changed the title Solve layout and announcement problems fix: solve layout and announcement problems May 31, 2024
Copy link

sonarqubecloud bot commented Jun 1, 2024

Copy link
Collaborator

@GaelCondeLosada GaelCondeLosada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM don't forget to address sonar cloud issues.

@alexandre-mrt alexandre-mrt merged commit 535debd into main Jun 1, 2024
3 checks passed
@GustaveCharles GustaveCharles linked an issue Jun 2, 2024 that may be closed by this pull request
@alexandre-mrt alexandre-mrt self-assigned this Jun 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add announcement matching based on interests
3 participants