-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Final end to end test and fixed #269
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Great work! Also very nice code coverage. Let me know if you need any help! |
GustaveCharles
approved these changes
Jun 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I solved the an issue showing user events in external profile instead of the contact events
How I did it
I modularised the Profile events allowing to pass in argument the correct userId. The component can now be re-used anywhere.
I added the end-to-end test for the M4 showing interactions with the app, including registration, login and walkthrough of the app
How to verify it
You can now check externals profiles the events should render correctly for your friends
You can run the maestro tests and observe the results in you emulator, like previous PR. Put the apk in your emulator.

You first have to install maestro with
curl -Ls "https://get.maestro.mobile.dev" | bash
and then runmaestro test <relative_path>
end-to-end-demo.mp4
if the end to end test fail on another's emulator it could be due to the user being authenticated with google and pop up screen could interfer.
Pre-merge checklist
The changes I have introduced: