Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Final end to end test and fixed #269

Merged
merged 23 commits into from
Jun 2, 2024
Merged

Final end to end test and fixed #269

merged 23 commits into from
Jun 2, 2024

Conversation

alexandre-mrt
Copy link
Collaborator

@alexandre-mrt alexandre-mrt commented Jun 2, 2024

What I did

I solved the an issue showing user events in external profile instead of the contact events

How I did it

I modularised the Profile events allowing to pass in argument the correct userId. The component can now be re-used anywhere.
I added the end-to-end test for the M4 showing interactions with the app, including registration, login and walkthrough of the app

How to verify it

You can now check externals profiles the events should render correctly for your friends

You can run the maestro tests and observe the results in you emulator, like previous PR. Put the apk in your emulator.
You first have to install maestro with curl -Ls "https://get.maestro.mobile.dev" | bash and then run maestro test <relative_path>
image

end-to-end-demo.mp4

if the end to end test fail on another's emulator it could be due to the user being authenticated with google and pop up screen could interfer.

Pre-merge checklist

The changes I have introduced:

  • work correctly
  • do not break other functionalities
  • work correctly on Android
  • are fully tested

@gaspardthrl
Copy link
Collaborator

gaspardthrl commented Jun 2, 2024

Great work! Also very nice code coverage. Let me know if you need any help!

@GustaveCharles GustaveCharles marked this pull request as ready for review June 2, 2024 17:12
Copy link
Collaborator

@GustaveCharles GustaveCharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@alexandre-mrt alexandre-mrt linked an issue Jun 2, 2024 that may be closed by this pull request
Copy link

sonarqubecloud bot commented Jun 2, 2024

@alexandre-mrt alexandre-mrt merged commit d896ea7 into main Jun 2, 2024
3 checks passed
@alexandre-mrt alexandre-mrt self-assigned this Jun 2, 2024
@alexandre-mrt alexandre-mrt linked an issue Jun 2, 2024 that may be closed by this pull request
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

finalize the end-to-end testing for the last M4 Set up compatible end to end testing
3 participants