-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: improved design and logic for M1 #61
Conversation
Added padding in the low bar and centered text inside the interest buttons
Added AuthenticationScreen to the userflow
Added feature that allows the user to click enter and directly go to the next input section
Now the screens only appear when the fonts finish loading and the interest grid is now a flat list.
Now the user can quit the keyboard by clicking outside of it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't have the time to check all the code in details but there are a few things that would require changes in my opinion.
-
First of all I suggest you can delete the file
AppContent.tsx
as it is not a part of the app. -
Secondly on Android there are a few problems:
After clicking on Add a description now, the button still says "Add a description now" and the bottom navigation bar is slightly cut out. However I think the navigation bar being slightly cut out is not a top priority problem to fix.
Another problem that's a bit more concerning is when trying to type a description, the keyboard goes over the description section.
Now users can pick their birth date in a much more intuitive way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall a very nice PR, let's try to make more smaller PRs next time as we discussed during the retrospective! Also I would recommend already removing all the semi-columns everywhere since this will come up as a conflict during merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me now, the layout is still not perfect with the keyboard on android but the functionality work fine. Date picker is functional on android. It is good enough for me we ca make another PR to fix small details later.
|
Fixing design and adding some logic
What was done?
What is there to do during the next milestone?
Unselected and selected interests