Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: improved design and logic for M1 #61

Merged
merged 13 commits into from
Apr 12, 2024
Merged

Conversation

Fyuryy
Copy link
Collaborator

@Fyuryy Fyuryy commented Apr 11, 2024

Fixing design and adding some logic

What was done?

  • Replaced Interest grid by FlatList component for performance reasons
  • Fixed textbox bug that didn't allow the user to click on the boxes
  • Added feature allowing the user to quit the keyboard by clicking on the screen
  • Added feature allowing the user to go to the next input box by clicking 'Enter'
  • Corrected selection colors in the interest selection list
  • Fonts load before any screen is displayed

What is there to do during the next milestone?

  • Add date picking feature to allow the user to input their birth date in an easier and more intuitive way.
  • Interactions with Fire base so that users can create accounts properly
  • Code the rest of the screens for the

Unselected and selected interests

Fyuryy added 8 commits April 10, 2024 15:54
Added padding in the low bar and centered text inside the interest buttons
Added AuthenticationScreen to the userflow
Added feature that allows the user to click enter and directly go to the next input section
Now the screens only appear when the fonts finish loading and the interest grid is now a flat list.
Now the user can quit the keyboard by clicking outside of it
Copy link
Collaborator

@GaelCondeLosada GaelCondeLosada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have the time to check all the code in details but there are a few things that would require changes in my opinion.

  • First of all I suggest you can delete the file AppContent.tsx as it is not a part of the app.

  • Secondly on Android there are a few problems:
    After clicking on Add a description now, the button still says "Add a description now" and the bottom navigation bar is slightly cut out. However I think the navigation bar being slightly cut out is not a top priority problem to fix.

WhatsApp Image 2024-04-11 at 20 55 04_a0c43edb

Another problem that's a bit more concerning is when trying to type a description, the keyboard goes over the description section.

WhatsApp Image 2024-04-11 at 20 55 07_63fa5a4f

@AlbertoCentonze AlbertoCentonze changed the title Fixing design and logic for Milestone 1 fix: improved design and logic for M1 Apr 12, 2024
Now users can pick their birth date in a much more intuitive way
Copy link
Collaborator

@AlbertoCentonze AlbertoCentonze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a very nice PR, let's try to make more smaller PRs next time as we discussed during the retrospective! Also I would recommend already removing all the semi-columns everywhere since this will come up as a conflict during merge.

Copy link
Collaborator

@AlbertoCentonze AlbertoCentonze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@GaelCondeLosada GaelCondeLosada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me now, the layout is still not perfect with the keyboard on android but the functionality work fine. Date picker is functional on android. It is good enough for me we ca make another PR to fix small details later.

@Fyuryy Fyuryy merged commit bfb7230 into main Apr 12, 2024
1 of 2 checks passed
Copy link

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants