Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: setup end to end #66

Merged
merged 4 commits into from
Apr 13, 2024
Merged

feat: setup end to end #66

merged 4 commits into from
Apr 13, 2024

Conversation

GustaveCharles
Copy link
Collaborator

What I did

  • Setup a framework for end to end tests.
  • Setup EAS build environment.

How I did it

I used the new Maestro framework. You can find the docs with this link . To make Maestro work you need to have an emulator. For this PR and for our actual eas.json, only an Android emulator works. You can setup Expo Orbit to manage emulators on this link

What it looks like

Enregistrement.de.l.ecran.2024-04-12.a.17.22.43.1.mov

@GustaveCharles GustaveCharles marked this pull request as ready for review April 12, 2024 16:12
@alexandre-mrt
Copy link
Collaborator

LGTM

@GustaveCharles GustaveCharles changed the title Setup end to end feat: setup end to end Apr 12, 2024
Copy link
Collaborator

@Aidasvenc Aidasvenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except that I think the .apk itself is not needed

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Aidasvenc Aidasvenc self-requested a review April 13, 2024 12:25
Copy link
Collaborator

@Aidasvenc Aidasvenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@Aidasvenc Aidasvenc merged commit 31c9263 into main Apr 13, 2024
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants