feat: added DescriptionScreen #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Overall I think the code is good, not much to say on that. And everything works fine on my phone. I think there are a few things we can discuss on the design .
On the information screen I think it would be a bit more intuitive if the navigation would stay at the bottom, this is also the way this screen was made in the figma.
On the description screen there are a few things that feel weird to me:
- The "validate" button icon, I prefer the way this button was in the figma.
- The border width is larger than in the rest of the app, I don't know if this is intentional (also in the figma, the border is black, I don't know if this looks better or not...)
- When validating the description we go forward in the registration with no feedback. I think I would feel better as a user if it would make me go back to the information screen and I would have to validate all the informations.
Aidasvenc
reviewed
Apr 18, 2024
Fyuryy
force-pushed
the
adding-description-feature
branch
from
0fee5e3 to
c9d18fb
Compare
Now the description screen is separated from the information screen
The design is much closer to figma now. Validate button gets the user to InformationScreen.
Added test for the passage to the DescriptionScreen
Fyuryy
force-pushed
the
adding-description-feature
branch
from
c9d18fb to
409f46b
Compare
|
Fyuryy
requested review from
gaspardthrl,
GustaveCharles,
GaelCondeLosada and
AlbertoCentonze
GustaveCharles
approved these changes
Apr 24, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the description screen is separated from the information screen
What I did
Created the Description Screen, its respective styles file and tested it
Made changes to Authentication Screen and Information Screen and their respective styles and test files.
Tested the DatePicker component
How I did it
Created a new folder called DescriptionScreen with a DescriptionScreen.tsx file and a style.ts file.
Used jest to test the respective screens and components.
How to verify it
Follow the registration process and at the InformationScreen click on Add description now
Click inside the box to open the keyboard and click outside of it to close it.
Click on the red icon to go to the InterestsScreen as intended.
There's no interaction to the Database yet in this screen.
Demo video
RPReplay_Final1713977420.MP4
Pre-merge checklist
The changes I have introduced: