Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Modernize CMake #1373

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Modernize CMake #1373

merged 1 commit into from
Mar 30, 2021

Conversation

mrexodia
Copy link
Contributor

@mrexodia mrexodia commented Feb 10, 2021

Did my best to modernize the CMake a bit and add options for installation/samples, which will allow users to add unicorn to their CMake projects by doing add_subdirectory (or FetchContent). Everything is backwards compatible and when installing unicorn I get the same outputs.

Example project that automatically downloads and compiles unicorn: https://github.com/mrexodia/unicorn_template

@mrexodia mrexodia marked this pull request as draft February 10, 2021 18:50
@mrexodia mrexodia marked this pull request as ready for review February 10, 2021 19:03
@wtdcode
Copy link
Member

wtdcode commented Mar 30, 2021

Nice contribution. Just a question: Does it also work with find_library?

@mrexodia
Copy link
Contributor Author

Everything is backwards compatible. In general you probably shouldn’t use find_library though, use find_package instead (although I don’t know if that works).

@wtdcode
Copy link
Member

wtdcode commented Mar 30, 2021 via email

@mrexodia
Copy link
Contributor Author

mrexodia commented Mar 30, 2021 via email

@aquynh aquynh merged commit 4440310 into unicorn-engine:master Mar 30, 2021
@aquynh
Copy link
Member

aquynh commented Mar 30, 2021

merged, thanks!

mrexodia added a commit to mrexodia/unicorn that referenced this pull request Jan 18, 2022
Everything from unicorn-engine#1373 seems to have been undone
@mrexodia mrexodia mentioned this pull request Jan 18, 2022
mrexodia added a commit to mrexodia/unicorn that referenced this pull request Jan 18, 2022
Everything from unicorn-engine#1373 seems to have been undone, so I did it again.
mrexodia added a commit to mrexodia/unicorn that referenced this pull request Jan 18, 2022
Everything from unicorn-engine#1373 seems to have been undone, so I did it again.
mrexodia added a commit to mrexodia/unicorn that referenced this pull request Jan 18, 2022
Everything from unicorn-engine#1373 seems to have been undone, so I did it again.
mrexodia added a commit to mrexodia/unicorn that referenced this pull request Jan 18, 2022
Everything from unicorn-engine#1373 seems to have been undone, so I did it again.
mrexodia added a commit to mrexodia/unicorn that referenced this pull request Jan 18, 2022
Everything from unicorn-engine#1373 seems to have been undone, so I did it again.
mrexodia added a commit to mrexodia/unicorn that referenced this pull request Jan 18, 2022
Everything from unicorn-engine#1373 seems to have been undone, so I did it again.
mrexodia added a commit to mrexodia/unicorn that referenced this pull request Jan 18, 2022
Everything from unicorn-engine#1373 seems to have been undone, so I did it again.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants