Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add name validation for PropertyOverride and FieldOverride #199

Open
ENikS opened this issue Mar 10, 2023 · 0 comments
Open

Add name validation for PropertyOverride and FieldOverride #199

ENikS opened this issue Mar 10, 2023 · 0 comments
Labels
Breaking change ❕ This change breaks public API Bug 🐛 release Release branch
Milestone

Comments

@ENikS
Copy link
Contributor

ENikS commented Mar 10, 2023

Description

The current implementation allows creation of overrides without specifying a field or property name.

var field = new FieldOverride(null, null);
var property = new PropertyOverride(null, null);

This is an error, and such overrides cause exceptions later on in the resolution. This condition must be handled in the constructor and throw ArgumentNullException.

@ENikS ENikS added Bug 🐛 Breaking change ❕ This change breaks public API labels Mar 10, 2023
@ENikS ENikS added this to the 6.0.0 milestone Mar 10, 2023
ENikS added a commit that referenced this issue Mar 10, 2023
@ENikS ENikS added the release Release branch label Mar 10, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Breaking change ❕ This change breaks public API Bug 🐛 release Release branch
Projects
None yet
Development

No branches or pull requests

1 participant