Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(resolver): avoid double slashes when joining id with /index #278

Merged
merged 6 commits into from
Oct 6, 2024

Conversation

itpropro
Copy link
Member

@itpropro itpropro commented Oct 2, 2024

Should fix DEP0166 (DeprecationWarning: Use of deprecated double slash resolving...) as mentioned in

Will not fix DEP0155 (DeprecationWarning: Use of deprecated trailing slash pattern mapping "./" in the "exports" field...).

@itpropro
Copy link
Member Author

itpropro commented Oct 2, 2024

@pi0 the test "follows symlinks" was already failing when I pulled the current version. Maybe connected to Windows?

@pi0 pi0 changed the title fix: Adjusted url join to avoid double slashes fix: url join to avoid double slashes Oct 6, 2024
@pi0 pi0 force-pushed the fix/moduleResolve branch from 235b667 to 7cc8645 Compare October 6, 2024 20:19
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

@pi0 pi0 changed the title fix: url join to avoid double slashes fix(resolver): avoid double slashes when joining id with /index Oct 6, 2024
@pi0 pi0 merged commit ff8db1e into main Oct 6, 2024
4 checks passed
@pi0 pi0 deleted the fix/moduleResolve branch October 6, 2024 20:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants