Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: correctly detect corepack for fallback #179

Merged
merged 2 commits into from
Jan 19, 2025

Conversation

pxslip
Copy link
Contributor

@pxslip pxslip commented Jan 15, 2025

Reproduction steps can be found at #178 (comment)

resolves #178

@pxslip pxslip marked this pull request as ready for review January 16, 2025 20:43
@pxslip
Copy link
Contributor Author

pxslip commented Jan 16, 2025

I was hoping to write a decent unit test for this, but couldn't come up with a solution that doesn't require rewriting GH Actions workflows. If someone has an idea I'd be happy to hear and implement it.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.77%. Comparing base (660392f) to head (7417c25).
Report is 73 commits behind head on main.

Files with missing lines Patch % Lines
src/_utils.ts 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #179       +/-   ##
===========================================
- Coverage   82.17%   64.77%   -17.40%     
===========================================
  Files           6        5        -1     
  Lines         516      494       -22     
  Branches       71       92       +21     
===========================================
- Hits          424      320      -104     
- Misses         91      171       +80     
- Partials        1        3        +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi0 pi0 changed the title fix: Correctly fallback to the current package manager when corepack is not present fix: correctly detect corepack Jan 19, 2025
@pi0 pi0 changed the title fix: correctly detect corepack fix: correctly detect corepack for fallback Jan 19, 2025
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnx!

@pi0 pi0 merged commit 4a1064b into unjs:main Jan 19, 2025
4 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On systems with pnpm managed node environments nypm throws an error for all operations
2 participants