-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
refactor!: improve library #75
Conversation
Codecov Report
@@ Coverage Diff @@
## main #75 +/- ##
==========================================
+ Coverage 96.53% 98.02% +1.48%
==========================================
Files 5 5
Lines 289 405 +116
Branches 34 64 +30
==========================================
+ Hits 279 397 +118
+ Misses 10 8 -2
|
LGTM |
Thanks so much for the time put into this PR dear @DamianGlowala ❤️ I have put a few refactors to keep the repo simplified and this mergeable. There are really nice changes and i don't want to miss them but i couldn't do it without making a breaking change release and we lack proper changelog... therefore i ask you to please next times, consider smaller mergable PRs 🙏🏼 |
This PR:
{}
)test/
folderutils/
directoryaddDevDependency
as deprecated (either we should provide equivalentremoveDevDependency
or might be better to delete it entirely) - open to opinions, but knowing this is as simple asaddDependency(name, { dev: true })
makes me think if we should get rid of it in a major releaseincludeParentDirs
option todetectPackageManager
util function, which prevents from bubbling the search up if not set totrue
explicitlyensurePackageInstalled
utility #53@pi0, are segmentation faults when using corepack with npm on ubuntu worth reporting? Will revert to the initial workaround for now anyway.