Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(DateField): Reset field segments when model value is undefined #1427

Merged
merged 1 commit into from
Nov 16, 2024
Merged

fix(DateField): Reset field segments when model value is undefined #1427

merged 1 commit into from
Nov 16, 2024

Conversation

epr3
Copy link
Collaborator

@epr3 epr3 commented Nov 15, 2024

Closes #1426.

@epr3 epr3 self-assigned this Nov 15, 2024
zernonia
zernonia approved these changes Nov 16, 2024
View reviewed changes
Copy link
Member

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zernonia zernonia merged commit 1714513 into main Nov 16, 2024
3 checks passed
@DamianGlowala
Copy link
Contributor

@epr3 I've installed https://pkg.pr.new/unovue/radix-vue/radix-vue@98ee034 to test this PR with attached component in the reproduction and sadly, I can't see any difference. Segments remain. LMK if you can reproduce too with my example.

@epr3 epr3 deleted the fix-date-field-1426 branch November 18, 2024 15:44
@epr3 epr3 mentioned this pull request Nov 18, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@DamianGlowala DamianGlowala DamianGlowala left review comments

@zernonia zernonia zernonia approved these changes

Assignees

@epr3 epr3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Setting date picker's model value to undefined doesn't reset field's segments
3 participants
@epr3 @DamianGlowala @zernonia