Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(Avatar): support referrer policy in AvatarImage.vue #1477

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

sadeghbarati
Copy link
Collaborator

(from radix-ui)

@sadeghbarati
Copy link
Collaborator Author

sadeghbarati commented Dec 4, 2024

I don't know when Vue is gonna support fallthroughAttributes and advanced types support for defineProps

cause I have a feeling that this is not ok to have an img component that doesn't have related attributes or props when we are in the IDE :'(

image

it should show alt on ctrl + space autocomplete suggestions

@zernonia
Copy link
Member

zernonia commented Dec 4, 2024

Thanks for the PR @sadeghbarati ! 💚

@zernonia zernonia merged commit a2d2b1a into main Dec 4, 2024
3 checks passed
@sadeghbarati sadeghbarati deleted the avatar-referrer-policy branch December 4, 2024 17:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants