Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: compatible with vue-loader experimentalInlineMatchResource #829

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Feb 21, 2025

Description

When using vue-loader experimentalInlineMatchResource, the request will have an additional .js/.ts extension to match the js/ts module rule

// without experimentalInlineMatchResource
- src/App.vue?vue&type=script&setup=true&lang=ts
// with experimentalInlineMatchResource
+ src/App.vue.ts?vue&type=script&setup=true&lang=ts

But the default include RegExps failed to match the request

Linked Issues

Additional context

@ahabhgk ahabhgk requested a review from antfu as a code owner February 21, 2025 12:02
Copy link

stackblitz bot commented Feb 21, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Co-authored-by: neverland <jait.chen@foxmail.com>
@chenjiahan
Copy link
Contributor

@antfu Can you take a look at this PR? ❤️

The background of this PR is that the latest version of Rspack aligns with webpack's Inline matchResource implementation, but this change will break users who are already using unplugin-vue-components and vue-loader's experimentalInlineMatchResource option. Therefore, we need to fix the matching through this PR.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants