Set end date #41
Open
Set end date #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linter insists that trailing whitespace should be removed. This isn’t the important part, but it makes the _actual_ commit harder to spot.
When the start date is changed we set the end date to that of the start date. But only if the user _hasn’t_ already set the end date, in which case we don’t change it.
|
Conflicts, any chance you could rebase it or just PR the specific commit, vs whitespace cleanup? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some whitespace cleanup makes it tricker to spot the actual change, which is here: revdancatt@195ebd6
This sets the end date calendar to match the start date when the start date is set or updated. However, if the user edits the end date by hand then further updating the start date will not modify the end date. This is to keep a balance between helping the user, and not stomping over their manual selection.
This is to answer issues: #33 and #23
Note This is on
add.jadeonly, notedit.jadeas it's assumed we only want the helper when first picking the dates, after that we're modifying the users already entered data.