-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: Add custom notifications for each site #255
base: master
Are you sure you want to change the base?
feat: Add custom notifications for each site #255
Conversation
@AnandChowdhary Any thoughts on this ? |
Looks good to me! If I understand it correctly, this PR only adds support for custom webhooks right? |
Currently yes but I am planning to add more. |
add sending logic with custom overrides
@AnandChowdhary This PR is almost finished, before I change the docs I want to explain what I've done and ask for review / opinion ✌️ I refactored the sending functionality and extract each send function in his own file where the checks and the setup are also placed. Furthermore I implemented the custom action logger |
@AnandChowdhary Any update on this ? |
As described in https://github.com/orgs/upptime/discussions/930 , it would be nice to set diffrent notification for each site.
I know that the isse proposed to add that feature to send emails but for the first step this PR only adds webhooks.
Before I invest more time in that, it would be nice to know if my intensions are right.
@AnandChowdhary Do you have any ideas or comments on that ?
Currently I would change the current behaviour to only send general notifications for sites that have no custom notification type set and the custom ones for that they are configurrf
Furthermore I can imagine to refactor the
update
andsendNotification
to make it more readable and easier to add more feature in the future.Feel free to comment ✌️
Best @coolusaHD