Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: dbfixture.New to accept IDB interface #900

Conversation

hirasawayuki
Copy link
Contributor

This PR addresses the limitation where the dbfixture.New function only accepts a pointer to bun.DB. Both bun.DB and bun.TX implement the IDB interface. By allowing dbfixture.New to accept the IDB interface, we provide more flexibility, especially during testing.

close #899

@hirasawayuki hirasawayuki force-pushed the enhance-idb-interface-support-dbfixture branch from 42d9515 to 71b2c90 Compare September 18, 2023 06:17
@hirasawayuki hirasawayuki changed the title enhance: dbfixture.New to accept IDB interface feat: dbfixture.New to accept IDB interface Sep 18, 2023
@vmihailenco vmihailenco merged commit 2dee174 into uptrace:master Sep 18, 2023
@vmihailenco
Copy link
Member

Thanks!

@hirasawayuki hirasawayuki deleted the enhance-idb-interface-support-dbfixture branch September 18, 2023 06:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow dbfixture.New to Accept the IDB Interface
2 participants