Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Extend add skip check certs #90

Closed
wants to merge 19 commits into from
Closed

Conversation

SuperKogito
Copy link
Member

@SuperKogito SuperKogito commented Feb 1, 2024

This is my PR to #89 (comment)
This includes:

  • Updated Regex
  • Commenting of links breaking the tests

I did not update the test workflow as I need time to figure that and test it thoroughly (which I cannot do tonight).

vsoch and others added 7 commits January 31, 2024 20:40
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
@SuperKogito SuperKogito requested a review from vsoch February 1, 2024 23:56
@vsoch
Copy link
Collaborator

vsoch commented Feb 2, 2024

@SuperKogito but I think you are making progress! I see more checks there than I did here. We will need to go through the failing tests carefully and craft new regular expressions - I don't have time soon but will add to my todo.

@SuperKogito
Copy link
Member Author

SuperKogito commented Feb 2, 2024

@vsoch what is happening is that, the worker run task is not being run on the GitHub server, ERROR - Error running task. Check the logs of my tests for more infos.
The worker task not being run/ dropped with an error returns empty results lists. Since results list is empty the assert fails.
Now we have to find out why this happens when tested online.

@vsoch
Copy link
Collaborator

vsoch commented Feb 2, 2024

@SuperKogito that just means that there is an error within the task. The way to debug is to run the same in serial, likely on a local machine so you can IPython.embed() and test why there are no match results for Urls (there should be) and then figure out how to update the regexes.

@SuperKogito
Copy link
Member Author

@vsoch I don't think that is the issue. Check my fifth and last commits above. I already tested in serial mode online and this fails (the same passes locally). The REGEX might need a revision but this is not a REGEX issue from what I see. The latest issue proves that. You can see the extracted URLs being correct, unless I am missing something here.

@vsoch vsoch force-pushed the add-skip-check-certs branch 2 times, most recently from 35a382e to a19bddd Compare February 3, 2024 22:38
Base automatically changed from add-skip-check-certs to master February 3, 2024 22:46
@vsoch
Copy link
Collaborator

vsoch commented Feb 27, 2024

I think we are good here and figured it out in #89. Thanks for your help here @SuperKogito !

@vsoch vsoch closed this Feb 27, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants