-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Extend add skip check certs #90
Conversation
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
@SuperKogito but I think you are making progress! I see more checks there than I did here. We will need to go through the failing tests carefully and craft new regular expressions - I don't have time soon but will add to my todo. |
@vsoch what is happening is that, the worker run task is not being run on the GitHub server, |
@SuperKogito that just means that there is an error within the task. The way to debug is to run the same in serial, likely on a local machine so you can IPython.embed() and test why there are no match results for Urls (there should be) and then figure out how to update the regexes. |
@vsoch I don't think that is the issue. Check my fifth and last commits above. I already tested in serial mode online and this fails (the same passes locally). The REGEX might need a revision but this is not a REGEX issue from what I see. The latest issue proves that. You can see the extracted URLs being correct, unless I am missing something here. |
35a382e
to
a19bddd
Compare
I think we are good here and figured it out in #89. Thanks for your help here @SuperKogito ! |
This is my PR to #89 (comment)
This includes:
I did not update the test workflow as I need time to figure that and test it thoroughly (which I cannot do tonight).