Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Style fixes for bugs #26 #28 #31 #36

Merged
merged 9 commits into from
Oct 7, 2015
Merged

Style fixes for bugs #26 #28 #31 #36

merged 9 commits into from
Oct 7, 2015

Conversation

swillard13
Copy link
Contributor

Fixed issues #26 #28 #31

@swillard13 swillard13 changed the title Style fixes for bugs #26 #28 #31 Style fixes for bugs Issue #26 #28 #31 Oct 7, 2015
@swillard13 swillard13 changed the title Style fixes for bugs Issue #26 #28 #31 Style fixes for bugs #26 #28 #31 Oct 7, 2015
.who-we-are {
background-image: url(../images/WhoWeAre/who-we-are-no-belt.svg);
background-position: right;
background-size: 1620px;
background-size: 1415px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you not use background-size: cover; or 100% here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want the background-size to be the same for all screen sizes showing that image so that the height doesn't have to grow.

@dcrousso
Copy link
Contributor

dcrousso commented Oct 7, 2015

LGTM

swillard13 added a commit that referenced this pull request Oct 7, 2015
@swillard13 swillard13 merged commit f91d51c into master Oct 7, 2015
@dcrousso dcrousso deleted the style-fixes branch October 9, 2015 07:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants