Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Traffic Incident Management: CARMA Web UI #74

Merged
merged 4 commits into from
Mar 19, 2021

Conversation

dan-du-car
Copy link
Contributor

@dan-du-car dan-du-car commented Mar 19, 2021

PR Details

Description

Add traffic event info panel
Add lane change status panel

Related Issue

Motivation and Context

Traffic Incident use case

How Has This Been Tested?

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    CARMA Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dan-du-car dan-du-car requested a review from maefromm March 19, 2021 18:33
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@maefromm
Copy link
Contributor

maefromm commented Mar 19, 2021

@dan-du-car as discussed I can merge this if it makes simpler for you with the conflicts. but the following needs to be addressed: 1) All the messages should match what's in the design document. 2) implement all the messages 3) EVENT REASON should not say "EVENT_REASON" twice. Make use of the mockup to say what we propsoed to the client.
@maefromm
It is removed at this commit
ad44d1f

@maefromm maefromm merged commit 7a68c9c into develop Mar 19, 2021
@maefromm maefromm deleted the feature/traffic_incident_UI branch March 19, 2021 19:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants