fix: better handling for nil results #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
better-handle-nil-results
branch
from
20fca58 to
720c63a
Compare
|
Is this ready for review now? |
shreddedbacon
approved these changes
Aug 13, 2024
shreddedbacon
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Checklist
A number of commands don't have validation on key flags which results in errors & nil results.
This adds additional validation & a helper func to better handle nil results. Also adds newlines where relevant due to the change in output in PR #364
A couple examples:
Nil results
Error due to non-existent project being passed -
lagoon delete org-p -p invalidProject --organization-name lagoon-demo-organization(More an api issue, but simple enough to handle here)