-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
improve: s3 store custom_domain #3717
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG otherwise
presignURL, err := s3Client.PresignGetObject(ctx, s3ObjectPayload.Key) | ||
if err != nil { | ||
return | ||
var referenceURL string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we skip this? This is the scheduler that refreshes the presigned time. For resources that use custom domain, we don't need to refresh its URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept this because when I set/unset custom domains, this scheduler will automatically update and switch to using the custom domain URL/presigned URL after the previous signature expires.
Close #3575