Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

improve: s3 store custom_domain #3717

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

kuusei
Copy link

@kuusei kuusei commented Jul 19, 2024

Close #3575

@kuusei kuusei requested a review from boojack as a code owner July 19, 2024 13:07
@kuusei kuusei changed the title improve: s3 store prefix url improve: s3 store custom_domain Jul 25, 2024
Copy link
Member

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG otherwise

presignURL, err := s3Client.PresignGetObject(ctx, s3ObjectPayload.Key)
if err != nil {
return
var referenceURL string
Copy link
Member

@boojack boojack Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we skip this? This is the scheduler that refreshes the presigned time. For resources that use custom domain, we don't need to refresh its URL.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept this because when I set/unset custom domains, this scheduler will automatically update and switch to using the custom domain URL/presigned URL after the previous signature expires.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

current version of S3 Storage cannot set url domain prefix
3 participants