-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Implementing chunk loading for SST1RSoXSLoader #113
Merged
pbeaucage
merged 7 commits into
usnistgov:main
from
phonghnguyen:SST1RSoXSLoader_chunk_loading
Mar 17, 2024
Merged
Implementing chunk loading for SST1RSoXSLoader #113
pbeaucage
merged 7 commits into
usnistgov:main
from
phonghnguyen:SST1RSoXSLoader_chunk_loading
Mar 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….imread.imread does not behave well with subsequent processing
pbeaucage
reviewed
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, once these issues are fixed CI tests should pass and then we can merge.
pbeaucage
reviewed
Mar 17, 2024
pbeaucage
approved these changes
Mar 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It passes CI, it looks good, thanks for the contribution!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added use_chunk_loading flag to load detector images as dask arrays for memory efficient data loading and processing