Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implementing chunk loading for SST1RSoXSLoader #113

Merged
merged 7 commits into from
Mar 17, 2024

Conversation

phonghnguyen
Copy link
Contributor

Added use_chunk_loading flag to load detector images as dask arrays for memory efficient data loading and processing

@pbeaucage pbeaucage self-requested a review March 15, 2024 15:48
Copy link
Collaborator

@pbeaucage pbeaucage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, once these issues are fixed CI tests should pass and then we can merge.

src/PyHyperScattering/SST1RSoXSLoader.py Outdated Show resolved Hide resolved
src/PyHyperScattering/SST1RSoXSLoader.py Show resolved Hide resolved
src/PyHyperScattering/SST1RSoXSLoader.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@pbeaucage pbeaucage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It passes CI, it looks good, thanks for the contribution!

@pbeaucage pbeaucage merged commit ee224b8 into usnistgov:main Mar 17, 2024
15 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants