Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PFEnergySeriesIntegrator bug: fix #125 #126

Conversation

pbeaucage
Copy link
Collaborator

@pbeaucage pbeaucage commented Apr 3, 2024

Fixes #125 by having the template xarray calibration loading function set energy as well, either to the scalar value or to the first value of a series.

@pbeaucage pbeaucage linked an issue Apr 3, 2024 that may be closed by this pull request
@pbeaucage pbeaucage changed the title Fix #125 PFEnergySeriesIntegrator bug: fix #125 Apr 3, 2024
@pbeaucage pbeaucage marked this pull request as ready for review April 4, 2024 02:22
@pbeaucage pbeaucage marked this pull request as draft April 4, 2024 02:32
@pbeaucage pbeaucage marked this pull request as ready for review April 4, 2024 02:36
Copy link
Collaborator

@BijalBPatel BijalBPatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@BijalBPatel BijalBPatel merged commit 20fed83 into main Apr 4, 2024
28 checks passed
@pbeaucage pbeaucage deleted the 125-bug-pfgeneralintegrator-does-not-load-energy-from-a-template-xarray branch April 5, 2024 20:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: PFGeneralIntegrator does not load energy from a template xarray
2 participants