Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add testing frameworks #1

Merged
merged 5 commits into from
Feb 2, 2023
Merged

Add testing frameworks #1

merged 5 commits into from
Feb 2, 2023

Conversation

DM1122
Copy link
Contributor

@DM1122 DM1122 commented Jan 19, 2023

Replaced Jasmine for Jest (unit testing) and Karma for Cypress (end-to-end testing). Cypress will need further configuration to work within Codespaces, but the writing of end-to-end tests is still some ways away.

Integration of these frameworks into a continuous integration pipeline was out of scope for this branch.

@DM1122 DM1122 added the enhancement New feature or request label Jan 19, 2023
@DM1122 DM1122 self-assigned this Jan 19, 2023
@jdtech3 jdtech3 added this to the MVP (Build V1) milestone Jan 19, 2023
@DM1122 DM1122 changed the title Add testing frameworks Draft: Add testing frameworks Jan 20, 2023
@DM1122 DM1122 marked this pull request as draft January 20, 2023 00:15
@DM1122 DM1122 changed the title Draft: Add testing frameworks Add testing frameworks Jan 20, 2023
@DM1122 DM1122 marked this pull request as ready for review January 23, 2023 17:08
Copy link
Contributor

@jdtech3 jdtech3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Should we put up an issue re: todo configure Cypress?

@DM1122
Copy link
Contributor Author

DM1122 commented Jan 24, 2023

Looks good! Should we put up an issue re: todo configure Cypress?

For sure, see #2

@stephanieyflu stephanieyflu requested a review from jdtech3 February 2, 2023 00:47
Copy link
Contributor

@jdtech3 jdtech3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See prior.

@DM1122 DM1122 merged commit 98fe2bf into dev Feb 2, 2023
@DM1122 DM1122 deleted the test_frameworks branch February 2, 2023 01:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants