Added code analyzer #8
Conversation
|
Please leave a review if any changes are required. Looking forward for a merge! |
|
I have ignored some errors, to pass, because I was unable to figure out the correct code. Can you please guide me so as to how to fix them? |
|
|
|
@Meldiron can you please review it? |
|
Thank you so much for the PR 🤩. We're adding the |
|
@Ambareen09 sorry for the delay. Would you please try and resolve the merge conflicts? |
stnguyen90
requested review from
stnguyen90 and
Meldiron
and removed request for
Meldiron and
stnguyen90
…alyzer-To-utopia-php/messaging
|
I have resolved merge conflict, can you please have a look? |
|
Hello, I see you have committed a few changes, you can let me know what all modifications do I need to do in order to make this a successful PR |
Ambareen09
requested review from
christyjacob4
and removed request for
Meldiron
…eat-4381-Add-Code-Analyzer-To-utopia-php/messaging
|
@christyjacob4 Looks like PHPStan checks are failing |
|
@Ambareen09 Thanks a lot for your contributions. I'll keep this PR open so it can be resolved at a later point. Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. |
Hey, thanks @christyjacob4 , I have already received my swags (as I opened other PRs too). |
|
Closing as implemented |
What does this PR do?
Updated the library utopia-php/messaging and implemented a code analyzer. I used PHPStan as the analyzer.
Test Plan
No issues were found upon running the code analyzer!
Related PRs and Issues
Add Code Analyzer To ‘utopia-php/messaging’(appwrite/appwrite#4381)
Have you read the Contributing Guidelines on issues?
Yes