fix: incorrect count of delayed jobs in the enqueueTransaction test #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
testciFix
We initially thought that #208 was a redis-related issue, but the actual problem was that other tests had pushed delayed jobs to the queue right before this one. This means that
jobs.delayedis not always guaranteed to be1, depending on the execution order of the tests (they normally run in parallel, so the order is not always the same).For example, check this action and search
jobs-xxxfor the log print of thejobslist, you should find 2 items in it, where one is our targeting item, and the other item belongs to another tests: https://github.com/ckb-cell/btc-assets-api/actions/runs/10662966768/job/29551165802#step:7:146