Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: replace optional-dev-dependencies with iodd #836

Merged
merged 2 commits into from
Nov 4, 2024
Merged

chore: replace optional-dev-dependencies with iodd #836

merged 2 commits into from
Nov 4, 2024

Conversation

broofa
Copy link
Member

@broofa broofa commented Nov 4, 2024

Replaces the defunct optional-dev-dependencies utility with the newly minted iodd script.

iodd is little more than an alias for npm install --no-save, passing it the packages defined in package.json#optionalDevDependencies. In fact, we could just hard-code a package.json#script that runs the same command. 'Might even be simpler, but iodd has the advantage of exiting gracefully if the packages fail to install, which is nice.

See also: bcoe/optional-dev-dependency#23

@broofa
Copy link
Member Author

broofa commented Nov 4, 2024

@ctavan: This seems to work (all checks passing), but I'll wait for your review on this since this was your code originally.

Copy link
Member

@ctavan ctavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think this is a good workaround!

@broofa broofa merged commit 383474d into main Nov 4, 2024
14 checks passed
@broofa broofa deleted the iodd branch November 4, 2024 20:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants