Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

install: fix symlink replacement behavior when using -C (--compare) option #7215

Closed
wants to merge 3 commits into from
Closed

install: fix symlink replacement behavior when using -C (--compare) option #7215

wants to merge 3 commits into from

Conversation

sylvestre
Copy link
Contributor

  • move to thiserror

@sylvestre sylvestre force-pushed the install branch 2 times, most recently from a031d71 to a38d008 Compare January 26, 2025 17:17
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/install/basic-1. tests/install/basic-1 is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/install/install-C is no longer failing!
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/install/install-C is no longer failing!
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

cakebaker
cakebaker reviewed Jan 27, 2025
View reviewed changes
tests/by-util/test_install.rs
@@ -1767,3 +1775,34 @@ fn test_install_from_stdin() {
assert!(at.file_exists(target));
assert_eq!(at.read(target), test_string);
}

#[test]
fn test_install_symlink_dest() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this test supposed to pass without the changes made to install.rs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question.
Tbh, I haven't been able to write a simple bash test case for this.
I did the implementation using the gnu test. Dunno why :(

@sylvestre sylvestre requested a review from cakebaker January 31, 2025 09:36
@sylvestre sylvestre closed this by deleting the head repository Feb 3, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tertsdiepraam tertsdiepraam Awaiting requested review from tertsdiepraam

@cakebaker cakebaker Awaiting requested review from cakebaker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvestre @cakebaker