Fix logger #19

MarisaKirisame · 2020-04-09T21:59:08Z

This pr stop creation of small ephemeral tensor, fixing logger bug where stuff is free before used, this bug is created by C++ destructors getting called in from_tensor.
This fix categorize tensor in overload into two category: checkpoint tensor and uncheckpoint tensor. previously uncheckpoint tensor is implicitly convert into checkpoint tensor, but now we track them distinctly, and do not convert any of them into checkpoint tensor for eviction purpose

aten/src/ATen/CheckpointTensorImpl.cpp

Implements CheckpointTensor backend Hook up the overload with a passing test. (#15) * save * save * review * review * add back files Adding some overload (#16) * save * save * review * remove outdated file * save * can compile again * save * save * up up array * finsih the overloads * replace vec[n] with vec.at(n) make resnet pass again, adding more logs for logging simulator (#17) * commit * add more overloads * fix log * save Logging everything for resnet (#18) * save * save * save * save * use release instead of free Fix logger (special handling for small constants) (#19) * save * fix comment TreeLSTM overloads (#21) Overloads for mean and mean.dim (needed for densenet) Add overloads for U-Net Add ability to annotate log and make new log file (#25) Restore overloads needed for LSTM and GRU Implemented unrolled_gan (#23) * save * save * save Overload bitwise and for ParityACT Add various overloads for ACT model Log aliases of operator outputs Overloads and changes needed for transformer Overloads for topk functions Add overloads for deepspeech More overloads for ACT DTR implementation first pass (#37) save before change save before change add aliaspool design, and add weak/strong pointer discussion add more code rebase add allocator hook save metadata to prepare for eviction save refactor: move log to a seprate file add file raii save save comment save save save save find error, bisecting code save save address review comment address comment address comment fix segfault save save pin save save save save save refactor - remove stitch save save [ impl ] overload diag & mv refactor - remove stitch save save restore equivalentclassnode save save save 50% resnet here we go 50% resnet here we go save save save save save save More opts save Try removing pop-ing from loop save save save save mike try this mike try this save undo system optimization for now save save save fix compile error save

Implements CheckpointTensor backend Hook up the overload with a passing test. (#15) * save * save * review * review * add back files Adding some overload (#16) * save * save * review * remove outdated file * save * can compile again * save * save * up up array * finsih the overloads * replace vec[n] with vec.at(n) make resnet pass again, adding more logs for logging simulator (#17) * commit * add more overloads * fix log * save Logging everything for resnet (#18) * save * save * save * save * use release instead of free Fix logger (special handling for small constants) (#19) * save * fix comment TreeLSTM overloads (#21) Overloads for mean and mean.dim (needed for densenet) Add overloads for U-Net Add ability to annotate log and make new log file (#25) Restore overloads needed for LSTM and GRU Implemented unrolled_gan (#23) * save * save * save Overload bitwise and for ParityACT Add various overloads for ACT model Log aliases of operator outputs Overloads and changes needed for transformer Overloads for topk functions Add overloads for deepspeech More overloads for ACT DTR implementation first pass (#37) save before change save before change add aliaspool design, and add weak/strong pointer discussion add more code rebase add allocator hook save metadata to prepare for eviction save refactor: move log to a seprate file add file raii save save comment save save save save find error, bisecting code save save address review comment address comment address comment fix segfault save save pin save save save save save refactor - remove stitch save save [ impl ] overload diag & mv refactor - remove stitch save save restore equivalentclassnode save save save 50% resnet here we go 50% resnet here we go save save save save save save More opts save Try removing pop-ing from loop save save save save mike try this mike try this save undo system optimization for now save save save fix compile error save save

Implements CheckpointTensor backend Hook up the overload with a passing test. (#15) * save * save * review * review * add back files Adding some overload (#16) * save * save * review * remove outdated file * save * can compile again * save * save * up up array * finsih the overloads * replace vec[n] with vec.at(n) make resnet pass again, adding more logs for logging simulator (#17) * commit * add more overloads * fix log * save Logging everything for resnet (#18) * save * save * save * save * use release instead of free Fix logger (special handling for small constants) (#19) * save * fix comment TreeLSTM overloads (#21) Overloads for mean and mean.dim (needed for densenet) Add overloads for U-Net Add ability to annotate log and make new log file (#25) Restore overloads needed for LSTM and GRU Implemented unrolled_gan (#23) * save * save * save Overload bitwise and for ParityACT Add various overloads for ACT model Log aliases of operator outputs Overloads and changes needed for transformer Overloads for topk functions Add overloads for deepspeech More overloads for ACT DTR implementation first pass (#37) save before change save before change add aliaspool design, and add weak/strong pointer discussion add more code rebase add allocator hook save metadata to prepare for eviction save refactor: move log to a seprate file add file raii save save comment save save save save find error, bisecting code save save address review comment address comment address comment fix segfault save save pin save save save save save refactor - remove stitch save save [ impl ] overload diag & mv refactor - remove stitch save save restore equivalentclassnode save save save 50% resnet here we go 50% resnet here we go save save save save save save More opts save Try removing pop-ing from loop save save save save mike try this mike try this save undo system optimization for now save save save fix compile error save save save save fix compile save fix save

Implements CheckpointTensor backend Hook up the overload with a passing test. (#15) * save * save * review * review * add back files Adding some overload (#16) * save * save * review * remove outdated file * save * can compile again * save * save * up up array * finsih the overloads * replace vec[n] with vec.at(n) make resnet pass again, adding more logs for logging simulator (#17) * commit * add more overloads * fix log * save Logging everything for resnet (#18) * save * save * save * save * use release instead of free Fix logger (special handling for small constants) (#19) * save * fix comment TreeLSTM overloads (#21) Overloads for mean and mean.dim (needed for densenet) Add overloads for U-Net Add ability to annotate log and make new log file (#25) Restore overloads needed for LSTM and GRU Implemented unrolled_gan (#23) * save * save * save Overload bitwise and for ParityACT Add various overloads for ACT model Log aliases of operator outputs Overloads and changes needed for transformer Overloads for topk functions Add overloads for deepspeech More overloads for ACT DTR implementation first pass (#37) save before change save before change add aliaspool design, and add weak/strong pointer discussion add more code rebase add allocator hook save metadata to prepare for eviction save refactor: move log to a seprate file add file raii save save comment save save save save find error, bisecting code save save address review comment address comment address comment fix segfault save save pin save save save save save refactor - remove stitch save save [ impl ] overload diag & mv refactor - remove stitch save save restore equivalentclassnode save save save 50% resnet here we go 50% resnet here we go save save save save save save More opts save Try removing pop-ing from loop save save save save mike try this mike try this save undo system optimization for now save save save fix compile error save save save save fix compile save fix save save [ restore ] overload for NLL loss2D Add an off switch for sampling, fix tense on 'shrinked' Add switch for ignoring small tensors fix some merge error save

Implements CheckpointTensor backend Hook up the overload with a passing test. (#15) * save * save * review * review * add back files Adding some overload (#16) * save * save * review * remove outdated file * save * can compile again * save * save * up up array * finsih the overloads * replace vec[n] with vec.at(n) make resnet pass again, adding more logs for logging simulator (#17) * commit * add more overloads * fix log * save Logging everything for resnet (#18) * save * save * save * save * use release instead of free Fix logger (special handling for small constants) (#19) * save * fix comment TreeLSTM overloads (#21) Overloads for mean and mean.dim (needed for densenet) Add overloads for U-Net Add ability to annotate log and make new log file (#25) Restore overloads needed for LSTM and GRU Implemented unrolled_gan (#23) * save * save * save Overload bitwise and for ParityACT Add various overloads for ACT model Log aliases of operator outputs Overloads and changes needed for transformer Overloads for topk functions Add overloads for deepspeech More overloads for ACT DTR implementation first pass (#37) save before change save before change add aliaspool design, and add weak/strong pointer discussion add more code rebase add allocator hook save metadata to prepare for eviction save refactor: move log to a seprate file add file raii save save comment save save save save find error, bisecting code save save address review comment address comment address comment fix segfault save save pin save save save save save refactor - remove stitch save save [ impl ] overload diag & mv refactor - remove stitch save save restore equivalentclassnode save save save 50% resnet here we go 50% resnet here we go save save save save save save More opts save Try removing pop-ing from loop save save save save mike try this mike try this save undo system optimization for now save save save fix compile error save save save save fix compile save fix save save [ restore ] overload for NLL loss2D Add an off switch for sampling, fix tense on 'shrinked' Add switch for ignoring small tensors

save

3063952

slyubomirsky reviewed Apr 14, 2020

View reviewed changes

aten/src/ATen/CheckpointTensorImpl.cpp Show resolved Hide resolved

fix comment

cf5ccd5

slyubomirsky merged commit dab0aa8 into cleanroom Apr 15, 2020

MarisaKirisame deleted the fix-logger branch May 13, 2020 16:43

MarisaKirisame mentioned this pull request Sep 30, 2020

Backend Cleanroom port (#13) #53

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix logger #19

Fix logger #19

MarisaKirisame commented Apr 9, 2020

Fix logger #19

Fix logger #19

Conversation

MarisaKirisame commented Apr 9, 2020