Merge pull request #17 from v-technologies/fix-null-affectation

fix: makes null affectations transparent in Simples_Document
v-technologies · Jun 29, 2016 · 5ea6a76 · 5ea6a76
2 parents 7a07b0e + 7163503
commit 5ea6a76
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/lib/Simples/Document.php b/lib/Simples/Document.php
@@ -240,7 +240,9 @@ public function __isset($path) {
 	 * @param mixed $value  Property value
 	 */
 	public function __set($name, $value) {
-		$this->set($name, $value) ;
+		if (!is_null($value)) {
+			$this->set($name, $value) ;
+		}
 	}
 
 	/**

diff --git a/tests/lib/Simples/DocumentTest.php b/tests/lib/Simples/DocumentTest.php
@@ -62,6 +62,22 @@ public function testAccessors() {
 
 
 	}
+
+
+	/**
+	 * BUG TEST
+	 * when setting a property to null, SimplesDocument would set the whole
+	 * data to the property name!
+	 * !16
+	 */
+	public function testNullAffectation() {
+		$document = new Simples_Document();
+
+		$document->a = null;
+
+		// we don't want null values... nor strange behaviors
+		$this->assertEquals(array(), $document->get());
+	}
 
 	public function testToArray() {
 		$document = new Simples_Document($this->data['standard']) ;