disable SystemCertPool error on Windows #1046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since it's not implemented golang/go#16736 Signed-off-by: Syrone Wong <wong.syrone@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1046 +/- ##
==========================================
+ Coverage 75.03% 75.15% +0.12%
==========================================
Files 225 225
Lines 9989 9990 +1
==========================================
+ Hits 7495 7508 +13
+ Misses 1780 1770 -10
+ Partials 714 712 -2
Continue to review full report at Codecov.
|
|
I'm not familiar with the golang philosophy. If you care the issue reported by codebeat, feel free to refine the code. |
|
Prefer conditional build as ccafce3 |
|
It's more elegant. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since it's not implemented
golang/go#16736
Signed-off-by: Syrone Wong wong.syrone@gmail.com