Update return type to throw Error instead of return null (#9)

v3xlabs · Jan 2, 2022 · aa9d1c7 · aa9d1c7
1 parent ef404ca
commit aa9d1c7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/hex2dec.ts b/src/hex2dec.ts
@@ -46,7 +46,7 @@ const parseToDigitsArray = (str: string, base: number) => {
     for (let i = digits.length - 1; i >= 0; i--) {
         let n = parseInt(digits[i], base);
 
-        if (isNaN(n)) return null;
+        if (isNaN(n)) throw new Error(`'${digits[i]}' is not a valid digit in base ${base}`);
 
         ary.push(n);
     }
@@ -57,8 +57,6 @@ const parseToDigitsArray = (str: string, base: number) => {
 const convertBase = (str: string, fromBase: number, toBase: number) => {
     let digits = parseToDigitsArray(str, fromBase);
 
-    if (digits === null) return null;
-
     let outArray: number[] = [];
     let power = [1];
     for (let i = 0; i < digits.length; i++) {

diff --git a/src/index.ts b/src/index.ts
@@ -20,7 +20,7 @@ export type SunflakeConfig = {
     epoch?: number;
 };
 
-export const generateSunflake = (config: SunflakeConfig) => async (time: number = Date.now()) => {
+export const generateSunflake = (config: SunflakeConfig) => async (time: number = Date.now()): Promise<string> => {
     let { machineID = 1, epoch = 1640988001000 } = config;
 
     lastTime = time;