Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: make app detected as Hilla in use #3219

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Conversation

tltv
Copy link
Member

@tltv tltv commented Feb 26, 2024

Empty route in routes.tsx is workaround for Flow hilla detection with alpha5. Also, adds missing @vaadin/hilla-lit-form dependency to package.json.

Related-To: vaadin/flow#18792

Empty route in routes.tsx is workaround for Flow hilla detection with alpha5.
Also, adds missing `@vaadin/hilla-lit-form` dependency to package.json.

Related-To: vaadin/flow#18792
@tltv tltv requested a review from mshabarov February 26, 2024 09:21
@github-actions github-actions bot added the Language unchecked English language and AsciiDoc formatting checks haven't been done label Feb 26, 2024
@mshabarov
Copy link
Contributor

@jouni could I merge this PR by myself, or you wanna take a look as well?

This makes Docs work with Vaadin 24.4.0.

@tarekoraby tarekoraby removed the Language unchecked English language and AsciiDoc formatting checks haven't been done label Feb 26, 2024
@mshabarov mshabarov merged commit 24cc201 into next Feb 27, 2024
3 checks passed
@mshabarov mshabarov deleted the chore/fix-for-244-alpha5 branch February 27, 2024 06:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants