fix: Lazy init of disable on click #4879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only init disable on click if actually enabled for button. Move function to buttonFunctions.js so each button only needs to call the function. Moving function makes 5000 buttons request 0.5 MB smaller and lazy init to only calll method for disbleOnClick buttons drops 1MB from the request.
tomivirkki
reviewed
Mar 27, 2023
...on-flow-parent/vaadin-button-flow/src/main/java/com/vaadin/flow/component/button/Button.java
Outdated
Show resolved
Hide resolved
...on-flow-parent/vaadin-button-flow/src/main/java/com/vaadin/flow/component/button/Button.java
Show resolved
Hide resolved
...-parent/vaadin-button-flow/src/main/resources/META-INF/resources/frontend/buttonFunctions.js
Outdated
Show resolved
Hide resolved
...on-flow-parent/vaadin-button-flow/src/main/java/com/vaadin/flow/component/button/Button.java
Outdated
Show resolved
Hide resolved
...-parent/vaadin-button-flow/src/main/resources/META-INF/resources/frontend/buttonFunctions.js
Outdated
Show resolved
Hide resolved
clean up code.
tomivirkki
reviewed
Mar 28, 2023
...on-flow-parent/vaadin-button-flow/src/main/java/com/vaadin/flow/component/button/Button.java
Outdated
Show resolved
Hide resolved
tomivirkki
reviewed
Mar 28, 2023
...-parent/vaadin-button-flow/src/main/resources/META-INF/resources/frontend/buttonFunctions.js
Outdated
Show resolved
Hide resolved
tomivirkki
reviewed
Mar 28, 2023
...-parent/vaadin-button-flow/src/main/resources/META-INF/resources/frontend/buttonFunctions.js
Outdated
Show resolved
Hide resolved
Only one executeJs should be queued for multiple calls to initDisableOnClick for one server roundtrip
|
Kudos, SonarCloud Quality Gate passed!
|
tomivirkki
approved these changes
Mar 28, 2023
|
This ticket/PR has been released with Vaadin 24.1.0.alpha2 and is also targeting the upcoming stable 24.1.0 version. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only init disable on click
if actually enabled for button.
Move function to buttonFunctions.js
so each button only needs to call the function.
Moving function makes 5000 buttons request
0.5 MB smaller and lazy init to only calll
method for disbleOnClick buttons drops 1MB
from the request.