Skip to content

Commit

Permalink
chore: Log the correct id (#20660) (#20665)
Browse files Browse the repository at this point in the history
Log the correct expected id.
the expected and checked id
is the clientId not the syncId

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
  • Loading branch information
vaadin-bot and caalador authored Dec 10, 2024
1 parent 4f8941e commit 75ced33
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ public void handleRpc(UI ui, String message, VaadinRequest request)
+ "This could happen for example during login process, if concurrent requests "
+ "are sent to the server and one of those changes the session identifier, "
+ "causing an UIDL request to be rejected because of session expiration. "
+ "Expected sync id: {}, got {}.",
+ "Expected client id: {}, got {}.",
expectedId, requestId);
} else {
/*
Expand All @@ -342,12 +342,12 @@ public void handleRpc(UI ui, String message, VaadinRequest request)
*/
String messageDetails = getMessageDetails(rpcRequest);
getLogger().debug("Unexpected message id from the client."
+ " Expected sync id: " + expectedId + ", got "
+ " Expected client id: " + expectedId + ", got "
+ requestId + ". Message start: " + messageDetails);
throw new UnsupportedOperationException(
"Unexpected message id from the client."
+ " Expected sync id: " + expectedId + ", got "
+ requestId
+ " Expected client id: " + expectedId
+ ", got " + requestId
+ ". more details logged on DEBUG level.");
}
} else {
Expand Down

0 comments on commit 75ced33

Please # to comment.