Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: client route collisions #20327

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

caalador
Copy link
Contributor

Fix the client server route
collision to not take into
account client layouts as
they are not route targets.

For instance

  {
    "route": "flow",
    "params": {},
    "children": [
      {
        "route": "hello-hilla",
        "menu": {
          "title": "Hello React in Flow Layout"
        },
        "title": "Hilla in Flow",
        "flowLayout": true,
        "params": {}
      }
    ]
  },

Collision on flow is wrong as the actual existing route is only flow/hello-hilla and thus should not match against a server route flow

Fix the client server route
collision to not take into
account client layouts as
they are not route targets.
@caalador caalador force-pushed the fix/client-route-check-not-match-layout branch from e69d3f2 to 8f30821 Compare October 24, 2024 07:21
Copy link

github-actions bot commented Oct 24, 2024

Test Results

1 142 files  ± 0  1 142 suites  ±0   1h 24m 29s ⏱️ +53s
7 474 tests + 2  7 424 ✅ + 2  50 💤 ±0  0 ❌ ±0 
7 801 runs   - 30  7 741 ✅  - 30  60 💤 ±0  0 ❌ ±0 

Results for commit 2cf7e0e. ± Comparison against base commit abddf7b.

♻️ This comment has been updated with latest results.

Copy link

@tltv tltv merged commit 3e0dfa7 into main Oct 24, 2024
26 checks passed
@tltv tltv deleted the fix/client-route-check-not-match-layout branch October 24, 2024 10:19
vaadin-bot pushed a commit that referenced this pull request Oct 24, 2024
Fix the client server route
collision to not take into
account client layouts as
they are not route targets.
vaadin-bot added a commit that referenced this pull request Oct 24, 2024
Fix the client server route
collision to not take into
account client layouts as
they are not route targets.

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.6.0.alpha2 and is also targeting the upcoming stable 24.6.0 version.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants