-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: remove modal component on route refresh #20540
fix: remove modal component on route refresh #20540
Conversation
Modal components attached to the UI were not removed or replaced during self-navigation triggered by a route refresh. This change updates navigation handler to ensure modal components are removed and adds a new navigation trigger for route refresh to differentiate programmatic navigations (e.g., forward actions). It also modifies Hotswapper to require a full chain refresh when modal components are present. Fixes #20473
bc0379c
to
4ef3417
Compare
flow-server/src/main/java/com/vaadin/flow/hotswap/Hotswapper.java
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Modal components attached to the UI were not removed or replaced during self-navigation triggered by a route refresh. This change updates navigation handler to ensure modal components are removed and adds a new navigation trigger for route refresh to differentiate programmatic navigations (e.g., forward actions). It also modifies Hotswapper to require a full chain refresh when modal components are present. Fixes #20473
Modal components attached to the UI were not removed or replaced during self-navigation triggered by a route refresh. This change updates navigation handler to ensure modal components are removed and adds a new navigation trigger for route refresh to differentiate programmatic navigations (e.g., forward actions). It also modifies Hotswapper to require a full chain refresh when modal components are present. Fixes #20473
Modal components attached to the UI were not removed or replaced during self-navigation triggered by a route refresh. This change updates navigation handler to ensure modal components are removed and adds a new navigation trigger for route refresh to differentiate programmatic navigations (e.g., forward actions). It also modifies Hotswapper to require a full chain refresh when modal components are present. Fixes #20473 Co-authored-by: Marco Collovati <marco@vaadin.com>
Modal components attached to the UI were not removed or replaced during self-navigation triggered by a route refresh. This change updates navigation handler to ensure modal components are removed and adds a new navigation trigger for route refresh to differentiate programmatic navigations (e.g., forward actions). It also modifies Hotswapper to require a full chain refresh when modal components are present. Fixes #20473 Co-authored-by: Marco Collovati <marco@vaadin.com>
We have tested Vaadin 24.5.7 and this fix cause issues on our side with our hotswap -it close opened modal dialogs randomly and influence the browser refresh behavior (e.g. via key F5 in chrome). |
@netsrotr do you mind creating a new ticket, providing a code example (or even better, a sample project) showing how you are using dialogs in the application? This would help us investigate further and see if we missed some use cases. |
Description
Modal components attached to the UI were not removed or replaced during self-navigation triggered by a route refresh.
This change updates navigation handler to ensure modal components are removed and adds a new navigation trigger for route refresh to differentiate programmatic navigations (e.g., forward actions).
It also modifies Hotswapper to require a full chain refresh when modal components are present.
Fixes #20473
Type of change
Checklist
Additional for
Feature
type of change