Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: service destroy listener exceptions #20622

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

tepi
Copy link
Contributor

@tepi tepi commented Dec 5, 2024

Related to #20577

Copy link

github-actions bot commented Dec 5, 2024

Test Results

1 158 files  ±0  1 158 suites  ±0   1h 34m 31s ⏱️ +46s
7 519 tests +2  7 466 ✅ +2  53 💤 ±0  0 ❌ ±0 
7 876 runs   - 7  7 814 ✅  - 7  62 💤 ±0  0 ❌ ±0 

Results for commit fd17bc7. ± Comparison against base commit 7a3569e.

♻️ This comment has been updated with latest results.

@tepi tepi changed the title Fix/service destroy listener exceptions fix: service destroy listener exceptions Dec 5, 2024
Copy link
Contributor

@caalador caalador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, but there should perhaps be a test with multiple listeners that check that they get called even if one or more throw an exception.

@tepi
Copy link
Contributor Author

tepi commented Dec 5, 2024

Looks ok, but there should perhaps be a test with multiple listeners that check that they get called even if one or more throw an exception.

Good point, I'll add a test. Maybe a similar one for SessionDestroyListener as well since the logic is there already but looks like no test for that either.

@tepi tepi requested a review from caalador December 5, 2024 17:12
@caalador caalador merged commit e988d48 into main Dec 9, 2024
26 checks passed
@caalador caalador deleted the fix/service-destroy-listener-exceptions branch December 9, 2024 06:42
vaadin-bot pushed a commit that referenced this pull request Dec 9, 2024
vaadin-bot pushed a commit that referenced this pull request Dec 9, 2024
vaadin-bot pushed a commit that referenced this pull request Dec 9, 2024
vaadin-bot added a commit that referenced this pull request Dec 9, 2024
Related to #20577

Co-authored-by: Teppo Kurki <teppo.kurki@vaadin.com>
vaadin-bot added a commit that referenced this pull request Dec 9, 2024
Related to #20577

Co-authored-by: Teppo Kurki <teppo.kurki@vaadin.com>
vaadin-bot added a commit that referenced this pull request Dec 9, 2024
Related to #20577

Co-authored-by: Teppo Kurki <teppo.kurki@vaadin.com>
Co-authored-by: Marco Collovati <marco@vaadin.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants