Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: appended path on fast navigate #20673

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

caalador
Copy link
Contributor

When navigating in quick succession
check that path starts with /
as else react will append to
current url.

Fixes #20671

When navigating in quick succession
check that path starts with /
as else react wll append to
current url.

Fixes #20671
Copy link

Test Results

1 158 files  ± 0  1 158 suites  ±0   1h 35m 48s ⏱️ + 9m 11s
7 520 tests ± 0  7 467 ✅ ± 0  53 💤 ±0  0 ❌ ±0 
7 888 runs  +21  7 826 ✅ +21  62 💤 ±0  0 ❌ ±0 

Results for commit 96fab0c. ± Comparison against base commit a784ea1.

@mshabarov mshabarov merged commit d17f169 into main Dec 11, 2024
26 checks passed
@mshabarov mshabarov deleted the issues/20671-appended-path branch December 11, 2024 10:53
vaadin-bot pushed a commit that referenced this pull request Dec 11, 2024
When navigating in quick succession
check that path starts with /
as else react wll append to
current url.

Fixes #20671
vaadin-bot pushed a commit that referenced this pull request Dec 11, 2024
When navigating in quick succession
check that path starts with /
as else react wll append to
current url.

Fixes #20671
vaadin-bot added a commit that referenced this pull request Dec 11, 2024
When navigating in quick succession
check that path starts with /
as else react wll append to
current url.

Fixes #20671

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
vaadin-bot added a commit that referenced this pull request Dec 11, 2024
When navigating in quick succession
check that path starts with /
as else react wll append to
current url.

Fixes #20671

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PiT] switching between different views results in wrong url
3 participants