Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: browser parsing (#20657) (CP: 24.6) #20683

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

* fix: browser parsing

Added new opera userAgent string.
Better logging for failures.
Better matching for version string.
Fixed android mistaken check.

Part of #20610

* Add ios firefox parsing

Add isIPad
Add testing userAgent strings
from json file.
Copy link

Test Results

1 159 files  ±0  1 159 suites  ±0   1h 33m 41s ⏱️ - 1m 5s
7 552 tests +7  7 498 ✅ +7  54 💤 ±0  0 ❌ ±0 
7 918 runs  +3  7 854 ✅ +2  64 💤 +1  0 ❌ ±0 

Results for commit 1c12646. ± Comparison against base commit 60a9597.

@mcollovati mcollovati merged commit 4c82e1e into 24.6 Dec 12, 2024
26 checks passed
@mcollovati mcollovati deleted the cherry-pick-20657-to-24.6-1733990514760 branch December 12, 2024 10:29
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 24.6.0.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants