fix(file-router): enable file routes + layout + fallback combination #2989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2989 +/- ##
==========================================
+ Coverage 92.52% 92.56% +0.03%
==========================================
Files 84 84
Lines 3159 3160 +1
Branches 770 772 +2
==========================================
+ Hits 2923 2925 +2
+ Misses 184 183 -1
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Artur-
approved these changes
Dec 10, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
ZheSun88
pushed a commit
that referenced
this pull request
Dec 10, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The combination use cases with file routes, server layout, and server fallback were broken in #2971. This fixes the combination issue and adds a test.