Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test(react-crud): Define locale for test #3054

Merged
merged 2 commits into from
Dec 19, 2024
Merged

test(react-crud): Define locale for test #3054

merged 2 commits into from
Dec 19, 2024

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Dec 19, 2024

No description provided.

@Artur- Artur- requested a review from platosha December 19, 2024 10:08
@platosha platosha changed the title test: Define locale for test test(react-crud): Define locale for test Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.57%. Comparing base (7b8f361) to head (cb892f9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3054   +/-   ##
=======================================
  Coverage   92.57%   92.57%           
=======================================
  Files          85       85           
  Lines        3166     3166           
  Branches      776      776           
=======================================
  Hits         2931     2931           
  Misses        183      183           
  Partials       52       52           
Flag Coverage Δ
unittests 92.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@platosha platosha enabled auto-merge (squash) December 19, 2024 10:42
@platosha platosha merged commit 43fc92d into main Dec 19, 2024
15 checks passed
@platosha platosha deleted the locale-test branch December 19, 2024 10:45
@vaadin-bot
Copy link
Collaborator

Hi @Artur- and @platosha, when i performed cherry-pick to this commit to 24.6, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 43fc92d
error: could not apply 43fc92d... test(react-crud): Define locale for test (#3054)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

cromoteca pushed a commit that referenced this pull request Jan 13, 2025
cromoteca added a commit that referenced this pull request Jan 14, 2025
test(react-crud): Define locale for test (#3054)

test: Define locale for test

Co-authored-by: Artur <artur@vaadin.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants