fix: throw exception if feature flag is not enabled (#2998) (CP: 24.6) #3086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: throw exception if feature flag is not enabled This also removes the client-side check for the feature flag to let the UI being rendered normally, and server-side get a chance to handle the requests for subscribe or update. Fixes #2937 * remove feature flag test * refine the import * apply changes from the review
|
taefi
approved these changes
Dec 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 24.6 #3086 +/- ##
=======================================
Coverage ? 92.66%
=======================================
Files ? 85
Lines ? 3164
Branches ? 775
=======================================
Hits ? 2932
Misses ? 181
Partials ? 51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This ticket/PR has been released with Hilla 24.6.1. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.