fix: prevent sending null session to backend connector (#159)

vaadin · Nov 27, 2024 · 978c7c6 · 978c7c6
1 parent 31c2a13
commit 978c7c6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/...starter/src/main/java/com/vaadin/kubernetes/starter/sessiontracker/SessionSerializer.java b/...starter/src/main/java/com/vaadin/kubernetes/starter/sessiontracker/SessionSerializer.java
@@ -279,7 +279,9 @@ private void queueSerialization(String sessionId,
                                 sessionId, clusterKey, error);
                     } else {
                         Consumer<SessionInfo> whenSerialized = sessionInfo -> {
-                            backendConnector.sendSession(sessionInfo);
+                            if (sessionInfo != null) {
+                                backendConnector.sendSession(sessionInfo);
+                            }
                             backendConnector
                                     .markSerializationComplete(clusterKey);
                         };

diff --git a/...ter/src/test/java/com/vaadin/kubernetes/starter/sessiontracker/SessionSerializerTest.java b/...ter/src/test/java/com/vaadin/kubernetes/starter/sessiontracker/SessionSerializerTest.java
@@ -291,7 +291,8 @@ void serialize_notSerializableException_notFallbackToPessimistic() {
         verify(connector).markSerializationStarted(clusterSID);
 
         await().atMost(500, MILLISECONDS).untilTrue(serializationCompleted);
-        verify(connector).sendSession(isNull());
+        verify(connector, never()).sendSession(any());
+        verify(connector).markSerializationComplete(clusterSID);
         locks.forEach(l -> verify(l, never()).lock());
 
     }