feat: Add test for mixed flowLayout and deep tree #7056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for testing use of flowLayout as both true and false in same layout path. Add test for hilla view with a deep path that should get a Flow layout.
manolo
requested changes
Dec 2, 2024
| } | ||
|
|
||
| @Test | ||
| public void hillaViewWithFlowOptOut() { |
There was a problem hiding this comment.
Both new tests are failing in CI, anything missing?
There was a problem hiding this comment.
the failure is expected as it needs the fix (vaadin/hilla#2934).
ZheSun88
changed the base branch from
main
to
update-flow-24.6.0.beta6-1732883390
ZheSun88
merged commit 88f4063
into
update-flow-24.6.0.beta6-1732883390
1 of 2 checks passed
ZheSun88
added a commit
that referenced
this pull request
Dec 3, 2024
* Update flow to 24.6.0.beta6 * feat: Add test for mixed flowLayout and deep tree (#7056) Add tests for testing use of flowLayout as both true and false in same layout path. Add test for hilla view with a deep path that should get a Flow layout. Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com> --------- Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com> Co-authored-by: caalador <mikael.grankvist@vaadin.com> Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com>
ZheSun88
added a commit
that referenced
this pull request
Dec 4, 2024
* Update flow to 24.6.0.beta7 * Update flow to 24.6.0.beta6 (#7059) * Update flow to 24.6.0.beta6 * feat: Add test for mixed flowLayout and deep tree (#7056) Add tests for testing use of flowLayout as both true and false in same layout path. Add test for hilla view with a deep path that should get a Flow layout. Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com> --------- Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com> Co-authored-by: caalador <mikael.grankvist@vaadin.com> Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com> --------- Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com> Co-authored-by: caalador <mikael.grankvist@vaadin.com> Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com>
ZheSun88
added a commit
that referenced
this pull request
Dec 4, 2024
* update hilla to 24.6.0.beta4 * Update flow to 24.6.0.beta7 (#7069) * Update flow to 24.6.0.beta7 * Update flow to 24.6.0.beta6 (#7059) * Update flow to 24.6.0.beta6 * feat: Add test for mixed flowLayout and deep tree (#7056) Add tests for testing use of flowLayout as both true and false in same layout path. Add test for hilla view with a deep path that should get a Flow layout. Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com> --------- Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com> Co-authored-by: caalador <mikael.grankvist@vaadin.com> Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com> --------- Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com> Co-authored-by: caalador <mikael.grankvist@vaadin.com> Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com> --------- Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com> Co-authored-by: caalador <mikael.grankvist@vaadin.com> Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com>
ZheSun88
added a commit
that referenced
this pull request
Dec 4, 2024
…7073) * update hilla to 24.6.0.beta5 * update hilla to 24.6.0.beta4 (#7072) * update hilla to 24.6.0.beta4 * Update flow to 24.6.0.beta7 (#7069) * Update flow to 24.6.0.beta7 * Update flow to 24.6.0.beta6 (#7059) * Update flow to 24.6.0.beta6 * feat: Add test for mixed flowLayout and deep tree (#7056) Add tests for testing use of flowLayout as both true and false in same layout path. Add test for hilla view with a deep path that should get a Flow layout. Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com> --------- Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com> Co-authored-by: caalador <mikael.grankvist@vaadin.com> Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com> --------- Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com> Co-authored-by: caalador <mikael.grankvist@vaadin.com> Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com> --------- Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com> Co-authored-by: caalador <mikael.grankvist@vaadin.com> Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com> * add wait until to hilla test * copilot beta3 --------- Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com> Co-authored-by: caalador <mikael.grankvist@vaadin.com> Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com> Co-authored-by: Zhe Sun <zhe@vaadin.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for testing use of
flowLayout as both true and false
in same layout path.
Add test for hilla view with a deep
path that should get a Flow layout.