Remove UMD bundle from package.json #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
chore/main-es-module
branch
from
29817b5 to
9b15f24
Compare
web-padawan
force-pushed
the
chore/main-es-module
branch
from
9b15f24 to
6391ee7
Compare
|
Reviewed 2 of 2 files at r1. Comments from Reviewable |
complete! all files reviewed, all discussions resolved
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #207
The UMD bundles is not processed correctly by
polymer-cli, which has its own AMD transform, resulting inwindow.defineis true, butwindow.define.amdis false.Leaving ES module as the only entry in package.json for now. For those who need UMD bundle, it is still there but should be included manually.
This change is