Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add searchParams for RouterLocation #582

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Conversation

haijian-vaadin
Copy link
Contributor

@haijian-vaadin haijian-vaadin commented Mar 12, 2021

For #498

@abdonrd
Copy link
Contributor

abdonrd commented May 17, 2021

@haijian-vaadin @platosha when a new release with this? Thanks!

@nChauhan91
Copy link

This feature searchParams shows it was merged into master a year ago & also is present in documentation but hasn't been released yet & in not present in current version 1.7.4 , is this correct or am i missing something?

getPageNumber(location) { return location.searchParams.get('page') || 'none'; }

@chumaltd
Copy link

@platosha +1 long awaited 1.7.5 release with this feature!!!

@danielquintero
Copy link

why is this closed? it is not included in 1.7.5 release... I tried npm i and downloading the sources, yet no reference to searchParams appears. Can someone do a fix release to include this?

@danielquintero
Copy link

@haijian-vaadin I am trying to use this feature however I am on 1.7.5 and I do not see any searchParams within location object, could you clarify if this landed in 1.7.5 or not?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants